[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4 of 5] [UPDATE] DisplayState interface change
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH 4 of 5] [UPDATE] DisplayState interface change |
Date: |
Tue, 25 Nov 2008 12:23:14 +0000 |
User-agent: |
Thunderbird 2.0.0.14 (X11/20080505) |
Anthony Liguori wrote:
> I'm not asking you to do that refactoring. But since we all pretty much
> agree that this is how things should look, I want to make sure that the
> DisplayState API takes all of this into account.
>
> So in that vein, I'd like to see all the things that call
> graphic_console_init changed to not take a DisplayState, but rather to
> have graphic_console_init() return an allocated DisplayState. These
> functions should then return a DisplayState which can be passed to VNC/SDL.
>
> From what I can tell, this is not a huge change. You shouldn't have to
> really touch any of the console code. I think this is important to sure
> up what the DisplayState API looks like and how the rest of QEMU
> interacts with it.
>
> If this seems like a major refactoring, let me know and either you're
> misunderstanding what I'm suggesting or I've miscalculated how much
> change is required here :-)
That's fine, it is a simple change, it was me that didn't understand
correctly what you were suggesting.
Since at the moment we don't have a DisplayState multiplexing function,
this means that we are going to keep the text_console_init as it is now
so that we can still the serial and the monitor interfaces, right?