[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix off-by-one bug limiting VNC passwords to 7
|
From: |
Chris Webb |
|
Subject: |
Re: [Qemu-devel] [PATCH] Fix off-by-one bug limiting VNC passwords to 7 chars |
|
Date: |
Tue, 25 Nov 2008 10:09:35 +0000 |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Thiemo Seufer <address@hidden> writes:
> Chris Webb wrote:
[...]
> > - monitor_readline("Password: ", 1, password, sizeof(password)-1);
> > + monitor_readline("Password: ", 1, password, sizeof(password));
> > password[sizeof(password)-1] = '\0';
>
> The next line can go as well, the string is already NULL terminated.
You're quite right. I'll update the two patches to reflect this change.
Cheers,
Chris.