qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/5] Remove tabs from qcow_aio_read_cb(). Fix in


From: Gleb Natapov
Subject: Re: [Qemu-devel] [PATCH 1/5] Remove tabs from qcow_aio_read_cb(). Fix indentation.
Date: Mon, 24 Nov 2008 22:03:43 +0200

On Mon, Nov 24, 2008 at 10:31:00AM -0600, Anthony Liguori wrote:
> Gleb Natapov wrote:
>> Signed-off-by: Gleb Natapov <address@hidden>
>> ---
>>
>>  block-qcow2.c |   78 
>> +++++++++++++++++++++++++++++----------------------------
>>  1 files changed, 39 insertions(+), 39 deletions(-)
>>
>> diff --git a/block-qcow2.c b/block-qcow2.c
>> index dc73769..ab19a4e 100644
>> --- a/block-qcow2.c
>> +++ b/block-qcow2.c
>> @@ -1186,7 +1186,7 @@ static void qcow_aio_read_cb(void *opaque, int ret)
>>       acb->hd_aiocb = NULL;
>>      if (ret < 0) {
>> -    fail:
>> +fail:
>>          acb->common.cb(acb->common.opaque, ret);
>>          qemu_aio_release(acb);
>>          return;
>> @@ -1200,8 +1200,8 @@ static void qcow_aio_read_cb(void *opaque, int ret)
>>      } else {
>>          if (s->crypt_method) {
>>              encrypt_sectors(s, acb->sector_num, acb->buf, acb->buf,
>> -                            acb->n, 0,
>> -                            &s->aes_decrypt_key);
>> +                    acb->n, 0,
>> +                    &s->aes_decrypt_key);
>>   
>
> Why did you change this indenting?  There is no tabs and I think it's  
> better the way it is than how you made it.
>
I reformatted the whole function with vi autoindent. I'll drop those two
lines.

--
                        Gleb.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]