[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3 of 5] [UPDATE] remove bgr
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH 3 of 5] [UPDATE] remove bgr |
Date: |
Fri, 21 Nov 2008 18:43:29 +0000 |
User-agent: |
Thunderbird 2.0.0.14 (X11/20080505) |
Anthony Liguori wrote:
> Stefano Stabellini wrote:
>> Do not handle bgr host displays in the backends.
>>
>
> -ETOOLITTLEDESCRIPTION
>
> Seriously though, where does bgr get handled now? Have you tested on a
> bgr display?
>
> The bgr code is notoriously easy to break right now so changes need
> testing.
>
Sorry you are right :)
I have written a little bit more about this in the first patch.
Right now a bgr flag exists so that sdl can set it, if the SDL_Surface
is bgr.
Afterwards vga.c does the needed conversion.
With my patches is sdl that is responsible for rendering the format
provided by vga.
Vga provides a DisplaySurface (ds->surface) in 16 or 32 bpp, rgb or bgr
does not matter.
Afterwards sdl creates a SDL_Surface from the given DisplaySurface and
blits it into the main SDL_Surface using SDL_BlitSurface.
Look at: sdl.c:sdl_setdata and sdl.c:sdl_update.
Everything is handled by sdl transparently.
No I didn't test it with a real bgr display ;)