Re: [Qemu-devel] [PATCH 1 of 2] [UPDATE] DisplayState interface change

[Anthony Liguori]

Paul Brook wrote:
> > There are really two parts to this patch.  One part is a completely
> > mechanical conversion of things like ds->linesize to
> > ds->surface->linesize.  The second is the guys of the API change.
> >
> > If you introduce accessors to access things like linesize from
> > DisplayState, so something like:
> >
> > int ds_get_linesize(DisplayState *ds) {
> >      return ds->linesize;
> > }
> >     
>
> I think this sort of thing should be going via the console structures.
> i.e. vga emulation deals entirely with a QEMUConsole.  sdl/vnc deal entirely 
> with a DisplayState, and qemu mediates in between.
>   

BTW, I really like the idea of just using DisplayState because it 
implies that you could stack these things in multiple orders.  For 
instance, you may want to have a DisplayState that took two 
DisplayStates, and produced a tiled image (think side-by-side VGA 
displays).  You may want to take that DisplayState and combine it with a 
DisplayState for serial/monitor/parallel so that you can switch by the 
side-by-side VGA display and the other consoles.

Using the same structure here gives you lots of flexibility in how you 
stack these things.

Regards,

Anthony Liguori

> Paul
>