[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support
From: |
François Revol |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support |
Date: |
Mon, 17 Nov 2008 23:30:53 +0100 CET |
> > - /* TODO: Implement compressed images. */
> > - if (hdr->ih_comp != IH_COMP_NONE) {
> > - fprintf(stderr, "Unable to load compressed u-boot images\
> > n");
> > + /* TODO bzip2 support */
> > + if (hdr->ih_comp == IH_COMP_BZIP2) {
> > + fprintf(stderr, "Unable to load bzip2 compressed u-boot
> > images\n");
> > goto fail;
> > }
> why do you remove the non compress mode?
He didn't remove it, he changed the check to only reject BZIP2, not
uncompressed (which is wrong though as it'd accept any other compession
including unknown).
> BTW Please note 2 thinks
> First this format of uImage is deprecated
> we have switch to a fdt uImage format
fdt ? as in flat device tree ?
Is that documented somewhere ?
I'll need to add U-Boot support to Haiku soon...
François.
- [Qemu-devel] improvements in uImage loading, Hollis Blanchard, 2008/11/17
- Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support, Hollis Blanchard, 2008/11/17
- Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support, Jean-Christophe PLAGNIOL-VILLARD, 2008/11/17
- Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support, Hollis Blanchard, 2008/11/18
- Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support, Anthony Liguori, 2008/11/18
- Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support, Hollis Blanchard, 2008/11/18
- Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support, Anthony Liguori, 2008/11/18
Re: [Qemu-devel] [PATCH 1/4] uImage: free file data after copying into guest memory, Anthony Liguori, 2008/11/18