[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] fix warnings on NetBSD
From: |
Blue Swirl |
Subject: |
[Qemu-devel] Re: [PATCH] fix warnings on NetBSD |
Date: |
Tue, 11 Nov 2008 19:45:49 +0200 |
On 11/11/08, Christoph Egger <address@hidden> wrote:
> On Monday 10 November 2008 17:56:58 Blue Swirl wrote:
> > On 11/10/08, Christoph Egger <address@hidden> wrote:
> > > On Monday 10 November 2008 17:03:27 Blue Swirl wrote:
> > > > On 11/10/08, Christoph Egger <address@hidden> wrote:
> > > > > Hi!
> > > > >
> > > > > Attached patch fixes a series of this warning
> > > > > when compiling on NetBSD:
> > > > >
> > > > > warning: array subscript has type 'char'
> > > >
> > > > There has been some discussion on ctype.h macro problems, please see:
> > > > http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg01239.html
> > > >
> > > > I'd vote for introducing qemu_isfoobar and qemu_towombat instead of
> > > > casts.
> > >
> > > Attached patch introduces a CTYPE macro as mentioned on this mail.
> > > The diff in qemu-common.h has been taken from xen ioemu.
> >
> > Sorry, you must have missed the two follow-up messages:
> > http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg01252.html
> > http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg01292.html
> >
> > So instead of CTYPE macro, there should be qemu_toupper, qemu_isalpha
> > etc. which handle char arguments correctly even when sign extension
> > happens.
>
>
> New patch attached. Better now ?
>
>
> Signed-off-by: Christoph Egger <address@hidden>
Looks good to me. Anybody mind if I commit it? Anthony, happy with this version?