qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix warnings : hw/fmopl.[ch] (BUILD_Y8950 is no


From: malc
Subject: Re: [Qemu-devel] [PATCH] Fix warnings : hw/fmopl.[ch] (BUILD_Y8950 is not defined)
Date: Tue, 11 Nov 2008 00:08:07 +0300 (MSK)

On Mon, 10 Nov 2008, Sylvain Petreolle wrote:

Signed-off by: Sylvain Petreolle<address@hidden>

Index: hw/fmopl.c
===================================================================
--- hw/fmopl.c    (r?vision 5668)
+++ hw/fmopl.c    (copie de travail)
@@ -813,7 +813,7 @@
                 }
             }
             return;
-#if BUILD_Y8950
+#ifdef BUILD_Y8950

[..snip..]



First of all fmopl.c is foreign code so touching it without clear need
would be a mistake, secondly, the same effect can be achieved by
#define BUILD_[Y8950|whatever] 0
in fmopl.h making for a much slimmer patch.

--
mailto:address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]