[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [Bochs-developers] [PATCH 2/6] Add S3 state to DSDT. Ha
|
From: |
Kevin O'Connor |
|
Subject: |
[Qemu-devel] Re: [Bochs-developers] [PATCH 2/6] Add S3 state to DSDT. Handle resumeevent in the BIOS. |
|
Date: |
Sun, 2 Nov 2008 11:31:59 -0500 |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Thu, Oct 30, 2008 at 11:41:28PM +0100, Sebastian Herbszt wrote:
> Gleb Natapov wrote:
> > + if (bios_table_cur_addr == 0)
> > + return 0;
>
> BX_USE_EBDA_TABLES case
[...]
> > + if (find_bios_table_area() < 0)
> > + return;
>
> It should not return if BX_USE_EBDA_TABLES is defined.
BX_USE_EBDA_TABLES is broken. I think we'd be better off removing it
instead of adding more to it.
-Kevin