Re: [Qemu-devel] Build breakage on OpenSolaris: --warn-common

[Andreas Färber]

Am 31.10.2008 um 22:27 schrieb Blue Swirl:

> On 10/31/08, Andreas Färber <address@hidden> wrote:
> > The following addition to configure at r5241 causes linking to fail  
> > on
> > OpenSolaris/amd64:
> >
> > if ld --version 2>/dev/null | grep -q "GNU ld" ; then
> >   LDFLAGS="$LDFLAGS -Wl,--warn-common"
> > fi
> >
> > Contrary to Solaris 10, OpenSolaris does use GNU ld. Might --warn- 
> > common
> > require an ld version newer than 2.15, or is this platform-dependent?
>
> According to binutils changelog, --warn-common was added in 1993, so
> maybe the platform breaks that. What does your ld print with ld
> --version?

GNU ld version 2.15
Copyright 2002 Free Software Foundation, Inc.
This program is free software; [...]

So definitely past 1993. Any thoughts what to check for?

> > Previously I had also reported that Solaris 10's grep rejects -q.  
> > Could we
> > use `grep "GNU ld" >/dev/null 2>/dev/null` instead?
>
> Sure.

I'll prepare a patch for that part then.

Andreas