[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] sh4: mmio based CF support on r2d board.
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] sh4: mmio based CF support on r2d board. |
Date: |
Mon, 27 Oct 2008 21:12:53 +0200 |
On 10/27/08, address@hidden <address@hidden> wrote:
> > This should be in a .h file (maybe pc.h), without "extern" and the
> > parameter names should be included.
>
> Sure. But, I wonder which file is suitable.
> The system I accustomed to is like
> - ide.c define function
> - ide.h declare prototype
> - pc.c include ide.h and refer the function.
> But in QEMU, it looks like
> - ide.c define function
> - pc.h declare prototype
> - pc.c include pc.h and refer the function.
I agree that the current .h system is not clear, I would prefer the
system you described. The reason is that otherwise there would be a
lot of files, many with just one function for device init.
> Is it mean the prototype declaration should go into new file "r2d.h" ?
How about sh.h? It's already included from r2d.c.