qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 06/32] split kqemu_init into two


From: Glauber Costa
Subject: [Qemu-devel] Re: [PATCH 06/32] split kqemu_init into two
Date: Thu, 23 Oct 2008 12:28:57 -0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Thu, Oct 23, 2008 at 08:58:48AM -0500, Anthony Liguori wrote:
> Glauber Costa wrote:
>> From: Glauber Costa <address@hidden>
>>
>> we separate kqemu_init() into a part that depends on env,
>> and other that does not. The later can be initialized earlier
>>   
>
> This patch seems harmless but I can't reasonably infer why this change  
> is necessary.  What's the advantage of splitting the initialization into  
> two parts?
>
the previous version receives a CPUState parameter. If we do that, we never 
give the accelerator the chance to care for its own CPUState. So that's the 
reason
behind the split: First, we kickstart the accelerator, which can suceed / fail.
Later on, we overwrite the cpu_env initialization to give the accel a chance.

> Regards,
>
> Anthony Liguori
>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]