[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 06/32] split kqemu_init into two
From: |
Glauber Costa |
Subject: |
[Qemu-devel] Re: [PATCH 06/32] split kqemu_init into two |
Date: |
Thu, 23 Oct 2008 12:28:57 -0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Thu, Oct 23, 2008 at 08:58:48AM -0500, Anthony Liguori wrote:
> Glauber Costa wrote:
>> From: Glauber Costa <address@hidden>
>>
>> we separate kqemu_init() into a part that depends on env,
>> and other that does not. The later can be initialized earlier
>>
>
> This patch seems harmless but I can't reasonably infer why this change
> is necessary. What's the advantage of splitting the initialization into
> two parts?
>
the previous version receives a CPUState parameter. If we do that, we never
give the accelerator the chance to care for its own CPUState. So that's the
reason
behind the split: First, we kickstart the accelerator, which can suceed / fail.
Later on, we overwrite the cpu_env initialization to give the accel a chance.
> Regards,
>
> Anthony Liguori
>
- [Qemu-devel] [PATCH 04/32] move kqemu_cpu_exec to kqemu.c, (continued)
- [Qemu-devel] [PATCH 04/32] move kqemu_cpu_exec to kqemu.c, Glauber Costa, 2008/10/23
- [Qemu-devel] [PATCH 05/32] use more meaningful values for kqemu_cpu_exec, Glauber Costa, 2008/10/23
- [Qemu-devel] [PATCH 07/32] introduce QEMUAccel and fill it with interrupt specific driver, Glauber Costa, 2008/10/23
- [Qemu-devel] [PATCH 06/32] split kqemu_init into two, Glauber Costa, 2008/10/23
- [Qemu-devel] [PATCH 08/32] init env made accel driver, Glauber Costa, 2008/10/23
- [Qemu-devel] [PATCH 09/32] wrap cache flushing functions into accel drivers, Glauber Costa, 2008/10/23
- [Qemu-devel] [PATCH 13/32] move disabling code to kqemu.c instead of vl.c, Glauber Costa, 2008/10/23
- [Qemu-devel] [PATCH 15/32] wrap modify_page through accel calls, Glauber Costa, 2008/10/23
- [Qemu-devel] [PATCH 18/32] provide --accel option, Glauber Costa, 2008/10/23
- [Qemu-devel] [PATCH 10/32] turn info kqemu into generic info accelerator, Glauber Costa, 2008/10/23
- [Qemu-devel] [PATCH 16/32] remove kqemu reference from hw/pc.c, Glauber Costa, 2008/10/23
- [Qemu-devel] [PATCH 12/32] move kqemu externs to kqemu.h, Glauber Costa, 2008/10/23