[Qemu-devel] Re: [PATCH 27/32] arch-specific hooks for accelerator

[Avi Kivity]

Jan Kiszka wrote:
> > >      void (*trace_io)(CPUState *env);
> > >      int (*break_loop)(CPUState *env);
> > >      int (*cpu_exec)(CPUState *env);
> > > +    void *arch; /* arch-specific accel functions */
> > >  } QEMUAccel
> > >       
> > This is more elegant IMO using container_of() and including the common
> > part as a member.  Less pointers to chase.
> >     
>
> ...or to have some kind of QEMUAccel_arch, defined in target-*/accel.h
> files. Haven't looked into the use cases yet to say what is sufficient.
>   

You're right, there's no need for run-time dynamic types here.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.