Re: [Qemu-devel] [PATCH] SH: Add prefi, icbi, synco

[Paul Brook]

> > The only cpu we currently claim to support is SH4. When adding support
> > for other cores these should be properly conditionalized. 
> > Unconditionally implementing additional instructions is a regression. I
> > don't consider "we'll fix this at some undefined point in the future" to
> > be a good enough answer.
>
> Can you outline what changes should I make to implement proper
> conditionalization?

You probably want something like ARM arm_feature, MIPS check_insn or
SPARC CHECK_*_FEATURE.

Paul