Re: [Qemu-devel] [PATCH] Davicom DM9000 emulation

[Paul Brook]

On Monday 13 October 2008, Daniel Silverstone wrote:
> Hi,
>
> Attached is a patch which provides Davicom DM9000E emulation support
> including the ability to compile in a pcap-style network trace of the
> device.

Network dumping does not belong in device specific code. It should be a 
separate device that can be attached to the virtual network.

> +#define DM9000_DBF(X...) if(0) fprintf(stderr, X)

This is wrong. Use do {} while(0)

> +/* hw/dm9000.h

A new header file for one init function is excessive. dm9000_init should go in 
the same place as smc91c111_init.

> +OBJS += dm9000.o

Likewise, this should be the same as smc91c111.o.

Paul