[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [5465] hw/apic.c: use __builtin funtions instead of ass
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [5465] hw/apic.c: use __builtin funtions instead of assembly code |
Date: |
Sun, 12 Oct 2008 12:21:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Aurelien Jarno wrote:
> Revision: 5465
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5465
> Author: aurel32
> Date: 2008-10-12 00:53:17 +0000 (Sun, 12 Oct 2008)
>
> Log Message:
> -----------
> hw/apic.c: use __builtin funtions instead of assembly code
>
> Suggested by malc.
>
> Signed-off-by: Aurelien Jarno <address@hidden>
>
> Modified Paths:
> --------------
> trunk/hw/apic.c
>
> Modified: trunk/hw/apic.c
> ===================================================================
> --- trunk/hw/apic.c 2008-10-12 00:53:08 UTC (rev 5464)
> +++ trunk/hw/apic.c 2008-10-12 00:53:17 UTC (rev 5465)
> @@ -104,15 +104,14 @@
> static void apic_set_irq(APICState *s, int vector_num, int trigger_mode);
> static void apic_update_irq(APICState *s);
>
> -/* Find first bit starting from msb. Return 0 if value = 0 */
> +/* Find first bit starting from msb */
> static int fls_bit(uint32_t value)
> {
> +#if defined(__GNUC__)
> + return 31 - __builtin_clz(value);
That as well as most (if not all) of the __builtin_* changes are gcc3.4+
stuff. Thus gcc3.3 builds are unfortunately broken now.
Jan
signature.asc
Description: OpenPGP digital signature