|
From: | Anthony Liguori |
Subject: | [Qemu-devel] Re: [PATCH] Add USB sys file-system support (v8) |
Date: | Tue, 07 Oct 2008 15:09:10 -0500 |
User-agent: | Thunderbird 2.0.0.17 (X11/20080925) |
TJ wrote:
A bug crept into the version 7 patch whilst editing to help pass checkpatch.pl tests. Inadvertently, in moving an assignment out of an if() condition I replaced it with a test against the wrong variable. This is the corrected patch. ====== Add USB sys file-system support This patch adds support for host USB devices discovered via: /sys/bus/usb/devices/* and opened from /dev/bus/usb/*/* /dev/bus/usb/devices and opened from /dev/bus/usb/*/* in addition to the existing discovery via: /proc/bus/usb/devices and opened from /proc/bus/usb/*/* Signed-off-by: TJ <address@hidden>
Applied. Thanks for keeping up with this patch. I'm very happy with how it turned out. One minor nit:
+static int usb_host_scan(void *opaque, USBScanFunc *func) +{ + FILE *f = 0; + DIR *dir = 0; + int ret = 0; + const char *devices = "/devices";+ const char *opened = "husb: opened %s%s\n";
When debug isn't enabled, these variables are unused and result in warnings (since they are only used in dprintf()). Could you follow up with a patch that either stuck these variables in an #ifdef or refactored the code to make these warnings disappear?
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |