[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers
From: |
Johannes Schindelin |
Subject: |
Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers |
Date: |
Mon, 6 Oct 2008 17:05:40 +0200 (CEST) |
User-agent: |
Alpine 1.00 (DEB 882 2007-12-20) |
Hi,
On Mon, 6 Oct 2008, Jes Sorensen wrote:
> This patch simply converts all the machine structs to use C99 style
> initializers. There is no actual code change in this.
Is it really such a good idea to do this? I mean, the only real change
you make here is to break compilation on compilers that do not grok C99
(or do it badly).
Sure, it does not concern _you_. You _obviously_ have a C99 compliant
compiler.
And do not even bother starting a discussion "but nobody has C89 compilers
anymore". There are people out there, and you _will_ hear from them, and
_only_ when it is too late.
So maybe it is time to step back and defend why you need to "fix"
something that already works pretty well? Or in the alternative, just
leave it?
Ciao,
Dscho
P.S.: before somebody says that GCC is C99 compliant: search the mailing
list for the Beos GCC2 issue which was mentioned not long ago.
- [Qemu-devel] [patch 1/2] machine struct - use C99 initializers, Jes Sorensen, 2008/10/06
- Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers,
Johannes Schindelin <=
- Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers, Jes Sorensen, 2008/10/06
- Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers, Ronan Keryell, 2008/10/06
- Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers, Andreas Färber, 2008/10/06
- Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers, Paul Brook, 2008/10/06
- Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers, M. Warner Losh, 2008/10/06
- Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers, Paul Brook, 2008/10/07
- Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers, Jes Sorensen, 2008/10/07
- Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers, Andreas Färber, 2008/10/26