[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] constant truncation warning in hw/pc.c for 32bit target
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] constant truncation warning in hw/pc.c for 32bit targets |
Date: |
Sun, 28 Sep 2008 16:52:22 +0300 |
On 9/28/08, Jindrich Makovicka <address@hidden> wrote:
> Hi,
>
> for 32bit targets, the 0x100000000ULL start address of above-4G memory
> is truncated to zero. IMO the code for above-4G allocation could be
> #ifdef'ed only for 64 bit targets, as for 32bit it 1) miscompiles and
> 2) won't be used anyway:
There are i386 systems with more than 4G of memory, so your patch is incorrect.
Now, if the code miscompiles there could be a problem somewhere else.