Re: [Qemu-devel] Re: [PATCH] add support for higher screen resolutions

[Anthony Liguori]

Samuel Thibault wrote:
> Andreas Winkelbauer, le Thu 18 Sep 2008 01:17:20 +0000, a écrit :
>   
> > Samuel Thibault <samuel.thibault <at> ens-lyon.org> writes:
> >     
> > > Andreas Winkelbauer, le Wed 17 Sep 2008 18:50:24 +0200, a écrit :
> > >       
> > > >  /* vga.c */
> > > >  
> > > >  #ifndef TARGET_SPARC
> > > > -#define VGA_RAM_SIZE (8192 * 1024)
> > > > +#define VGA_RAM_SIZE (16 * 1024 * 1024)
> > > >  #else
> > > >         
> > > Mmm, did you check that save/restore works between before and after the
> > > change?
> > >       
> > Are there some problems due to this change?
> >     
>
> I haven't tested myself with plain qemu, but with xen ioemu I had
> troubles when I tried to change the video memory size.
>
>   
> > I would be very surprised if this change breaks save/restore, since kvm uses
> > this patch for quite a long time now and there were no complaints about
> > save/restore not working.
> >     

The problem is that a patch like this will break save/restore across 
different versions of QEMU.  The fact that this isn't easily detected is 
a problem that would be nice to fix.

Has vgabios cut a release with the patch required for this?  Does the 
KVM version of vgabios contain any other patches?

Regards,

Anthony Liguori


> Including on upgrade?
>
> Samuel
>
>
>