qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/x v2] [ppc] Convert op_reset_T0, op_set_{T0, T


From: Aurélien Jarno
Subject: Re: [Qemu-devel] [PATCH 2/x v2] [ppc] Convert op_reset_T0, op_set_{T0, T1} to TCG
Date: Wed, 3 Sep 2008 01:28:00 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Tue, Sep 02, 2008 at 06:44:59PM +0200, Andreas Färber wrote:
>
> Am 02.09.2008 um 17:58 schrieb Aurelien Jarno:
>
>> On Tue, Sep 02, 2008 at 04:32:11PM +0200, Andreas Färber wrote:
>>> Hello,
>>>
>>> The attached patch replaces op_reset_T0, op_set_T0 and op_set_T1 with
>>> tcg_gen_movi_{tl,i32}.
>>
>> Given that cpu_T* are TL registers, the use of tcg_gen_movi_i32() is  
>> not
>> correct here. tcg_gen_movi_tl() should use instead. If the value  
>> really
>> have to be casted to 32-bit, this as to be done in the argument.
>
> Done. (There appeared to be no need for casting.)

Applied, thanks.

>
> Signed-off-by: Andreas Faerber <address@hidden>
>
> Andreas
>


>


-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net




reply via email to

[Prev in Thread] Current Thread [Next in Thread]