Re: [Qemu-devel] [PATCH] usb-linux.c: #define __user to work around broken Linux headers

[Ian Jackson]

Thiemo Seufer writes ("Re: [Qemu-devel] [PATCH] usb-linux.c: #define __user to 
work around broken Linux headers"):
> It was rejected because distros should fix their broken headers instead.

I think this is an absurd response.

On that theory, why do we bother with any of the other portability
stuff in qemu ?  We could do away with the hideously complicated
emulation of openpty and just say `distros should get openpty'.

Why do we bother with special cases like this one (block-raw-posix.c):

  #if defined(__GLIBC__) && defined(__linux__)
      {
          /* XXX: aio thread exit seems to hang on RedHat 9 and this init
             seems to fix the problem. */

etc. etc.

I agree that distros should fix their broken headers.  Indeed none of
the systems I have here and which I use for testing have headers which
are broken in this way.

However, it would be nice to be able to make qemu work on old systems,
even if those systems have bugs.  Unless you have a time machine which
we can use to fix up this kind of thing in (say) Fedora Core 6 ?

Ian.