qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [5087] Fix more bugs in r5044


From: Igor Kovalenko
Subject: Re: [Qemu-devel] [5087] Fix more bugs in r5044
Date: Tue, 26 Aug 2008 01:10:59 +0400

On Tue, Aug 26, 2008 at 12:43 AM, Blue Swirl <address@hidden> wrote:
> Revision: 5087
>          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5087
> Author:   blueswir1
> Date:     2008-08-25 20:43:37 +0000 (Mon, 25 Aug 2008)
>
> Log Message:
> -----------
> Fix more bugs in r5044
>
> Modified Paths:
> --------------
>    trunk/audio/audio.c
>    trunk/i386-dis.c
>
> Modified: trunk/i386-dis.c
> ===================================================================
> --- trunk/i386-dis.c    2008-08-25 20:03:28 UTC (rev 5086)
> +++ trunk/i386-dis.c    2008-08-25 20:43:37 UTC (rev 5087)
> @@ -2826,7 +2826,7 @@
>  oappend (s)
>      const char *s;
>  {
> -  pstrcpy (obufp, (size_t)(obufp - obuf), s);
> +  pstrcpy (obufp, sizeof(obuf) - (size_t)(obufp - obuf), s);
>   obufp += strlen (s);
>  }
>
>

Now the disassembler output is truncated; you need to revert this part
of change to i386-dis.c
The problem is that obufp is not always a pointer into obuf data, see
i386-dis.c:2497      obufp = op1out;

-- 
Kind regards,
Igor V. Kovalenko




reply via email to

[Prev in Thread] Current Thread [Next in Thread]