qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 4/6] Use libuuid if available.


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v2 4/6] Use libuuid if available.
Date: Mon, 25 Aug 2008 13:45:53 +0200


Am 25.08.2008 um 13:26 schrieb Gleb Natapov:

On Mon, Aug 25, 2008 at 01:08:50PM +0200, Andreas Färber wrote:

Am 25.08.2008 um 11:58 schrieb Gleb Natapov:

If libuuid is available use it for UUID generation in case a user does
not
provide one.

Signed-off-by: Gleb Natapov <address@hidden>
---

I don't remember hearing an answer on why this is necessary. For which
use case can't you just either use -uuid `uuidgen` or a hardcoded
default value like the Slirp IPv4 subnet?
It can be used for UUID generation when VM is started for the first time.
Management application can retrieve UUID using monitor and use it for
consequent runs. But the same result can be achieved in a different way too. So no, I really don't have a strong use case for this feature, but
the patch set is organised in such way that it is possible to ignore
this particular patch.

Okay, then I'd ask to invert the logic so that the user has to explicitly ask for it, maybe -uuid random (setting generate_uuid = 0 by default and =1 in that case). Then no accidental damage should be done and a Management Application can still use it.

Andreas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]