qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [5083] PPC: Switch a few instructions to TCG


From: J. Mayer
Subject: Re: [Qemu-devel] [5083] PPC: Switch a few instructions to TCG
Date: Mon, 25 Aug 2008 00:08:17 +0200

On Sun, 2008-08-24 at 19:05 +0000, Aurelien Jarno wrote:
> Revision: 5083
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5083
> Author:   aurel32
> Date:     2008-08-24 19:05:35 +0000 (Sun, 24 Aug 2008)
> 
> Log Message:
> -----------
> PPC: Switch a few instructions to TCG

It seems like you forgot to consider that I might be working on this
subject, as I announced here last month and care if you break my work in
any way.
Then, you also "forgot" to wait for the fixes needed to address
regression that have been introduced by previous inconsidered commits in
PowerPC emulation: I also said that this was the _first thing_ to be
done before anything else in PowePC code. 
Then, I can be sure that you "forgot" to test if your patch breaks any
PowerPC targets, as some do not run now...
Last but not least, you also "forgot" to submit your patch, wait for
comments, reviews, tests...

All this is unacceptable; furthermore, just giving a quick look, there
seem to be many things that should never have been commited as-is and
have to be fixed before this set of could eventually be merged.

Please revert_ now_.
Thanks by advance.

-- 
J. Mayer <address@hidden>
Never organized





reply via email to

[Prev in Thread] Current Thread [Next in Thread]