[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation.
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation. |
Date: |
Fri, 22 Aug 2008 17:04:44 +0200 |
User-agent: |
Thunderbird 2.0.0.16 (X11/20080723) |
Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> The patch also adds a XenEvtOps struct with function pointers for the
>> xc_evtchn_* family, which is used to switch between libxenctrl and the
>> qemu implementation at runtime. By default libxenctrl is used.
>
> I suppose the QEMU implementation is to eventually eliminate the need
> for libxc?
Yes, for xen emulation (aka xenner).
When running on Xen libxc is still needed of course.
> Do you also plan on doing a XenStore implementation within QEMU?
Yes.
>> @@ -521,6 +521,7 @@ endif
>> # xen backend driver support
>> XEN_OBJS := xen_machine_pv.o xen_backend.o xen_devconfig.o
>> xen_domainbuild.o
>> XEN_OBJS += xen_console.o xen_framebuffer.o xen_disk.o xen_nic.o
>> +XEN_OBJS += xenner_libxc_evtchn.o
>
> Historically, we didn't have directories in QEMU because we used CVS and
> directories are a nightmare. With the shear number of files being added
> for Xen, it probably makes sense to stick them all in a directory.
Hmm, the xen guys vetoed file renames, so I don't feel like sticking
stuff used by xen somewhere else. For the emulation bits aka
xenner*.[ch] it should be no problem though. New xenner/ toplevel
directory?
> Minor nit, make sure to have copyrights in all of your files.
> [ ... more review comments ... ]
Thanks, I'll fix it up.
cheers,
Gerd
- [Qemu-devel] [PATCH 0/2] RfC: xenner (aka xen emulation) bits., Gerd Hoffmann, 2008/08/22
- [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation., Gerd Hoffmann, 2008/08/22
- Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation., Anthony Liguori, 2008/08/22
- Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation.,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation., Gerd Hoffmann, 2008/08/25
- Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation., Anthony Liguori, 2008/08/25
- Re: [Xen-devel] Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation., Keir Fraser, 2008/08/26
- Re: [Xen-devel] Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation., Anthony Liguori, 2008/08/25
- Re: [Xen-devel] Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation., Keir Fraser, 2008/08/26
- Re: [Xen-devel] Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation., Gerd Hoffmann, 2008/08/26
- Re: [Xen-devel] Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation., Keir Fraser, 2008/08/26
- Re: [Xen-devel] Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation., Daniel P. Berrange, 2008/08/26
[Qemu-devel] [PATCH 2/2] xenner: use evtchn function pointers in the backends., Gerd Hoffmann, 2008/08/22
Message not available