Re: [Qemu-devel] [PATCH] Flush pending AIO on reboot and shutdown.

[Avi Kivity]

Anthony Liguori wrote:
> Avi Kivity wrote:
> > Anthony Liguori wrote:
> > > > I though about doing it this way, but then I saw that 
> > > > qemu_register_reset()
> > > > is used for HW reset notification only. I don't think that hw/ide.c 
> > > > is the
> > > > right place to register the notifier though, so I decided to call it
> > > > explicitly. Do you think I should do qemu_register_reset() in block.c?
> > > >   
> > >
> > > But shouldn't the various disk types be the ones to flush their 
> > > outstanding IO on reset?
> >
> > Do you mean qemu block drivers, or disk controllers?
>
> The disk controllers.  It's a semantic of the disk controller itself 
> (what happens on reset if there are outstanding requests).  Do those 
> requests complete or are the cancelled?

I imagine it depends on the controller, and that they are allowed to 
drop pending requests.  If software wants data on the disk, it should 
wait for completion.

--
error compiling committee.c: too many arguments to function