qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Handle terminating signals.


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] Handle terminating signals.
Date: Mon, 11 Aug 2008 21:46:42 +0200
User-agent: Thunderbird 2.0.0.16 (X11/20080723)

Ian Jackson wrote:
> Gerd Hoffmann writes ("[Qemu-devel] [PATCH] Handle terminating signals."):
>> This patch makes qemu handle signals better.  For normal signals
>> (SIGINT, SIGTERM & friends) it just sets the request_shutdown flag,
>> making the main_loop exit and qemu taking the usual exit route, with
>> atexit handlers being called and so on, instead of qemu just being
>> killed by the signal.
>>
>> +    sigaction(SIGINT,  &act, NULL);
>> +    sigaction(SIGHUP,  &act, NULL);
>> +    sigaction(SIGTERM, &act, NULL);
>> +    sigaction(SIGQUIT, &act, NULL);
> 
> SIGQUIT should not be in this list.  QUIT does not mean `please
> terminate'.  It's a signal used for debugging purposes and usually
> means `please pretend this program took a SEGV'.  The default action
> is to die and dump core, and this should be preserved.

Ok, we could take the SIGSEGV cleanup route, then call abort().  That
should come close enougth.  Does that sound ok?

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]