|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmissing-prototypes |
Date: | Mon, 11 Aug 2008 11:47:03 -0500 |
User-agent: | Thunderbird 2.0.0.14 (X11/20080501) |
Avi Kivity wrote:
You lose the switch(nb_args) in monitor_handle_command() so it comes out even. You don't need to cast anything -- though you do need to change all the callbacks to accept an argument array.
And to either explicitly cast each argument or explicitly parse each argument. It touches quite a bit of places in the code and makes the callbacks quite a bit more complicated.
Using a void * is a one line change and works on all modern systems. Seems like a winner to me :-)
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |