[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] another SPARC issue
From: |
Laurent Desnogues |
Subject: |
Re: [Qemu-devel] another SPARC issue |
Date: |
Wed, 6 Aug 2008 10:17:26 +0200 |
On Wed, Aug 6, 2008 at 4:33 AM, Vince Weaver <address@hidden> wrote:
>
> From what I can tell from the sparcv9 manual this patch is correct, but I
> might be missing something.
>
> --- translate.c.org 2008-08-05 22:30:15.000000000 -0400
> +++ translate.c 2008-08-05 22:30:26.000000000 -0400
> @@ -1641,13 +1641,11 @@
> #ifdef TARGET_SPARC64
> static inline TCGv gen_get_asi(int insn, TCGv r_addr)
> {
> - int asi, offset;
> + int asi;
> TCGv r_asi;
>
> if (IS_IMM) {
> r_asi = tcg_temp_new(TCG_TYPE_I32);
> - offset = GET_FIELD(insn, 25, 31);
> - tcg_gen_addi_tl(r_addr, r_addr, offset);
> tcg_gen_ld_i32(r_asi, cpu_env, offsetof(CPUSPARCState, asi));
> } else {
> asi = GET_FIELD(insn, 19, 26);
My understanding of v9 manual is the same as yours. Your patch looks
correct.
Laurent