Re: [Qemu-devel] [PATCH 2/3]: Add -uuid option to Qemu

[Gerd Hoffmann]

Chris Lalancette wrote:
> Gerd Hoffmann wrote:
>> Chris Lalancette wrote:
>>> As suggested by Anthony, this patch and the next one were split apart.  This
>>> patch just adds the basic plumbing to qemu to be able to set the uuid on the
>>> command-line, and retrieve the information via "info uuid".
>> What is the point of CONFIG_UUID and the libuuid test in that patch?
>> I can't see any dependency on it in the source code.  IMHO the -uuid
>> switch should be present unconditionally.
> 
> Hm, CONFIG_UUID is used, for instance, to control whether we output the -uuid
> part of the help string.  There are other uses in the patch as well.

Sure.

> I think the problem with including it unconditionally is that it drags in the
> uuid library, which may or may not always be available.

Does it?  As far I can see none of the bits wrapped into #ifdef
CONFIG_UUID actually calls that library.

If you wanna do stuff like generating a uuid in case none was specified
on the command line, _then_ you'll need libuuid and those parts should
be compiled conditionally.  I don't see the point for the -uuid cmd line
switch though.

Gleb's patches seem to have organized things this way according to his
reply (didn't check list archive).

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/