|
| From: | Blue Swirl |
| Subject: | Re: [Qemu-devel] [PATCH 4/7] xen: add framebuffer backend driver |
| Date: | Mon, 4 Aug 2008 20:09:23 +0300 |
On 8/4/08, Gerd Hoffmann <address@hidden> wrote:
> +const unsigned char atkbd_set2_keycode[512] = {
Missing "static"?
> +const unsigned char atkbd_unxlate_table[128] = {
Ditto.
> + for (i = 0; i < 128; i++) {
> + scancode2linux[i] = atkbd_set2_keycode[atkbd_unxlate_table[i]];
> + scancode2linux[i | 0x80] =
> + atkbd_set2_keycode[atkbd_unxlate_table[i] | 0x80];
> + }
Can't these table be calculated so that this initial run-time lookup
is not needed?
The framebuffer does not use dirty memory detection. Is this
intentional? I understand that in Xen that's not possible.
| [Prev in Thread] | Current Thread | [Next in Thread] |