|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH 3/7] xen: add console backend driver. |
Date: | Mon, 28 Jul 2008 14:04:20 -0500 |
User-agent: | Thunderbird 2.0.0.14 (X11/20080501) |
Gerd Hoffmann wrote:
+ +struct devops xen_console_ops = {I missed it in the previous patchset, but it would be nice to QEMU-ify these things. For instance, 'struct xen_console' => 'XenConsole', 'struct devopts' => 'XenDevOpts', etc.Hmm, I will if I have to. But I don't like that style very much and a quick grep through the qemu header files shows that the CapsStyle isn't used consequently everythere. I see a happy style mix. The core structures tend to be CapsStyle though ...
I much prefer the Linux style myself, but I prefer consistency over any particular style. I think it would be good to modify the code to be consistent with the rest of the core QEMU structure.
Regards, Anthony Liguori
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |