Re: [Qemu-devel] [4932] Preliminary PPC64/Linux host support

[C.W. Betts]

On Jul 26, 2008, at 7:08 AM, Andreas Färber wrote:

> Am 25.07.2008 um 20:18 schrieb malc:
>
> > On Thu, 24 Jul 2008, C.W. Betts wrote:
> >
> > > Building it under OS X 10.5.4 doesn't work.  After editing the  
> > > config-host files, I get the following:
> > > In file included from /Users/cwbetts/makestuff/qemu-allmac/src/ 
> > > exec-all.h:320,
> > >              from /Users/cwbetts/makestuff/qemu-allmac/src/vl.c:136:
> > > /Users/cwbetts/makestuff/qemu-allmac/src/qemu-lock.h:216:2: error:  
> > > #error unimplemented CPU support
> > >
> > > After adding
> > > #define __powerpc__ 1
> > > #define __powerpc64__ 1
>
> I don't think it's is a good idea to define these as such, it may  
> confuse other software. You should check the places where they are  
> used and add appropriate checks for either __ppc__ or __ppc64__  
> respectively (they are never defined at the same time, contrary to  
> Linux).
When ARCH=ppc is defined in config-host.mak, it adds -D__powerpc__ to  
the compiler command line.  However, it doesn't seem to do that when  
it is defined as ppc64.  I also remember seeing __powerpc64__  
mentioned in the patch.
> > > It chokes up under
> > > In file included from /usr/include/inttypes.h:255,
> > >              from /Users/cwbetts/makestuff/qemu-allmac/src/cpu- 
> > > defs.h:29,
> > >              from /Users/cwbetts/makestuff/qemu-allmac/src/target- 
> > > i386/exec.h:30,
> > >              from /Users/cwbetts/makestuff/qemu-allmac/src/cpu- 
> > > exec.c:22:
> > > /usr/lib/gcc/powerpc-apple-darwin9/4.2.1/include/stdint.h:35:  
> > > error: conflicting types for ?int64_t?
> > > /Users/cwbetts/makestuff/qemu-allmac/src/dyngen-exec.h:59: error:  
> > > previous declaration of ?int64_t? was here
> > > /usr/lib/gcc/powerpc-apple-darwin9/4.2.1/include/stdint.h:55:  
> > > error: conflicting types for ?uint64_t?
> > > /Users/cwbetts/makestuff/qemu-allmac/src/dyngen-exec.h:42: error:  
> > > previous declaration of ?uint64_t? was here
> > > make: *** [cpu-exec.o] Error 1
> >
> > Uh, weird,
>
> Well, afaik dyngen didn't have support for ppc64...
I usually touch dyngen to make it not compile.  I think cpu-exec.c  
includes dyngen-exec.h.