[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [4875] Remove unintended dereference, kills a warning (
|
From: |
Andreas Schwab |
|
Subject: |
Re: [Qemu-devel] [4875] Remove unintended dereference, kills a warning (Jan Kiszka). |
|
Date: |
Wed, 16 Jul 2008 14:04:38 +0200 |
|
User-agent: |
Gnus/5.110009 (No Gnus v0.9) Emacs/22.2 (gnu/linux) |
Andrzej Zaborowski <address@hidden> writes:
> void OPPROTO op_tasb_rN(void)
> {
> - cond_t(*(int8_t *) env->gregs[PARAM1] == 0);
> - *(int8_t *) env->gregs[PARAM1] |= 0x80;
> + cond_t((env->gregs[PARAM1] && 0xff) == 0);
> + *(int8_t *) &env->gregs[PARAM1] |= 0x80;
That does not make any sense at all. The TAS insn operates on memory,
not on a register (atomic operations only make sense on memory anyway).
Andreas.
--
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."