[Qemu-devel] Re: [PATCH 7/13] Restore pc on watchpoint hits

[Jan Kiszka]

Paul Brook wrote:
> On Thursday 03 July 2008, Jan Kiszka wrote:
>> In order to provide accurate information about the triggering
>> instruction, this patch adds the required bits to restore the pc if the
>> access happened inside a TB. With the BP_STOP_BEFORE_ACCESS flag, the
>> watchpoint user can control if the debug trap should be issued on or
>> after the accessing instruction.
> 
> I'm fairly sure this won't work. What happens when an interrupt occurs?

When in interrupt is raised before the watchpoint is re-triggered (after
restore), it might be handled first - hmm... Maybe this has to be
prevented to avoid inconsistencies (ie. no guest IRQ delivery when
watchpoints are pending). Will check again and update the patch.

Jan

signature.asc
Description: OpenPGP digital signature