Re: [Qemu-devel] [4799] Add instruction counter.

[J. Mayer]

On Sun, 2008-06-29 at 13:28 +0100, Paul Brook wrote:
> > +    int done_init = 0;
> > +    if (done_init)
> > +        return;
> > +    cpu_env = tcg_global_reg_new(TCG_TYPE_PTR, TCG_AREG0, "env");
> > +    done_init = 1;
> > +}
> >
> > - done_init is on the stack, thus will never be 1.
> 
> Fixed.

thanks

> > - why isn't this variable / code shared with other targets (can see the
> > exact same code in Alpha target...) ?
> 
> Maybe. Most targets have many globals and cpu_env is the only one that's 
> really target independent. alpha and ppc are only the same because they still 
> haven't been converted to TCG.

OK, I see.

-- 
J. Mayer <address@hidden>
Never organized