qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qcow2: improve I/O performance with cache=off


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH] qcow2: improve I/O performance with cache=off
Date: Wed, 25 Jun 2008 10:43:01 +0200
User-agent: Thunderbird 2.0.0.12 (X11/20071114)

Hi Laurent,

Laurent Vivier schrieb:
I modify this patch according Avi comments, and I'll repost it.

Thank you for your comments.

It's certainly a good idea to add the change suggested by Avi. But don't you think you'd better make a second patch out of it, on top of this one? I feel that the patch to get_cluster_offset might not be too small for itself.

Oh, and while you're at it... ;-) I think this function could use at least some more comments, and splitting out some parts as new functions could also help with its readability.

Kevin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]