qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 0/5] Debugger enhancements


From: Jan Kiszka
Subject: [Qemu-devel] Re: [PATCH 0/5] Debugger enhancements
Date: Sun, 01 Jun 2008 15:54:22 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

Fabrice Bellard wrote:
> Paul Brook wrote:
>>> 2) The current watchpoint code is not implemented correctly so it is not
>>> safe to improve it using the same system (IMHO it should not have been
>>> commited in its current state). A correct implementation should not
>>> delay the DEBUG exception. It should be implemented like the "normal"
>>> MMU exceptions.
>> On most targets watchpoint traps occur after the instruction completes, so 
>> you 
>> have to defer the DEBUG exception.
>> Normal MMU faults occur before the instruction completes.
> 
> If this is the wanted behavior then the same system as the Self
> Modifying Code on x86 should be used. Basically it consists in doing as
> a MMU fault and single stepping one instruction after. Unfortunately I
> fear the implementation will be complicated.

It isn't, in fact, and it allows for a few nice cleanups. I've a working
version here now, based on a new singlestep_enable flag. Will re-post my
whole series once I've integrated your other remarks.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]