Re: [Qemu-devel] [PATCH 0/5] Debugger enhancements

[Fabrice Bellard]

Hi,

I cannot accept the patches for several reasons:

1) You mix cosmetic and functional patches.

2) The current watchpoint code is not implemented correctly so it is not
safe to improve it using the same system (IMHO it should not have been
commited in its current state). A correct implementation should not
delay the DEBUG exception. It should be implemented like the "normal"
MMU exceptions.

Regards,

Fabrice.

Jan Kiszka wrote:
> This patch series strives at improving QEMU /wrt guest debugging - for
> me a very important use case of this software.
> 
> It consists of patches that refactor and enhance the
> breakpoint/watchpoint support, originally driven by the need to extend
> QEMU's internal API in order to enhance (real) hardware-assisted
> debugging in KVM. But as the KVM maintainer refused to merge the core of
> my patches until the QEMU bits went mainline, I was forced to rebase
> them immediately :->. In fact, these patches now come with even more
> added value also for QEMU, ie. full watchpoint support with exact PC
> addresses.
> 
> Moreover, the series contains an old, unmerged patch of mine that
> improves the debugability of SMP guests. For this submission, I
> basically rebased and polished it further. I'm using it for months now
> as it is de facto mandatory for SMP debugging.
> 
> Please review!
> 
> Jan
> 
> 
> 
>