Re: [Qemu-devel] [4597] CRIS: Re-add the X flag to the tb flags, it allows for better code generation and is practially always cleared.

[Edgar E. Iglesias]

On Tue, May 27, 2008 at 11:30:02PM +0100, Paul Brook wrote:
> On Tuesday 27 May 2008, Edgar E. Iglesias wrote:
> > Revision: 4597
> >           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4597
> > Author:   edgar_igl
> > Date:     2008-05-27 21:15:56 +0000 (Tue, 27 May 2008)
> >
> > Log Message:
> > -----------
> > CRIS: Re-add the X flag to the tb flags, it allows for better code
> > generation and is practially always cleared.
> 
> Are you sure this is safe? It means you shouldn't do TB chaining from any 
> block that modifies the X flag, and I don't see any code for that.

I wouldn't expect the cris translator to handle broken X sequences (it's a 
TODO). I'll look into it when adding proper X flag support.

Thanks for the hint, I didn't know the target specific code was responsible for 
assuring flag consistency at tb chaining.

Best regards
-- 
Edgar E. Iglesias
Axis Communications AB