[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [4254] Let WM8750 users write to audio buffer directly.
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [4254] Let WM8750 users write to audio buffer directly. |
Date: |
Sun, 27 Apr 2008 01:31:30 +0200 |
User-agent: |
Thunderbird 2.0.0.12 (X11/20080226) |
andrzej zaborowski wrote:
> On 26/04/2008, Jan Kiszka <address@hidden> wrote:
>> andrzej zaborowski wrote:
>> > On 26/04/2008, Jan Kiszka <address@hidden> wrote:
>> >> Andrzej Zaborowski wrote:
>> >> > Revision: 4254
>> >> >
>> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4254
>> >> > Author: balrog
>> >> > Date: 2008-04-26 12:00:18 +0000 (Sat, 26 Apr 2008)
>> >> >
>> >> > Log Message:
>> >> > -----------
>> >> > Let WM8750 users write to audio buffer directly.
>> >>
>> >>
>> >> Works - but who is now in charge of applying volume and mute settings,
>> >> the wm8750 on dac_commit or its user? Or do you plan to switch to
>> >> AUD-level control directly?
>> >
>> > The wm8750 for sure, maybe in wm8750_out_flush just before
>> > AUD_write(). But I'm not sure that it's a useful feature enough to do
>> > it in software. I'd rather wait until there appears a generic mixer
>> > api (don't know about any plans).
>>
>>
>> Hmm, unfortunate situation. We currently even have the regression that
>> muting, which worked fine with the wm8750 before, is now broken and
>
> Yes, my doubt is if there is a use case in which this ever makes a
> difference (and if it's valid for svn users), i.e. when you can't use
> the host's mixer (using a mixer app outside qemu). With the
> VirtualBox style mixer api the guest and host mixers can be the same
> and that would be best to have.
[ Digging through VBox's patch chaos... ] Just to ensure I got it right:
You mean dropping vol from SWVoiceOut/In in favor of those global
pcm_out/in_volume?
And then it looks like the software volume conversion is already in
place, no further patching required? That would indeed be simple.
Jan
signature.asc
Description: OpenPGP digital signature