qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 2 of 4] [qemu ppc uic] Remove interrupt polarity cod


From: Hollis Blanchard
Subject: [Qemu-devel] [PATCH 2 of 4] [qemu ppc uic] Remove interrupt polarity code
Date: Wed, 23 Apr 2008 17:23:53 -0500

Interrupt polarity should have no functional effect, since qemu tracks logical
IRQ state, not the electrical state of physical lines.

Signed-off-by: Hollis Blanchard <address@hidden>

diff --git a/qemu/hw/ppc4xx_devs.c b/qemu/hw/ppc4xx_devs.c
--- a/qemu/hw/ppc4xx_devs.c
+++ b/qemu/hw/ppc4xx_devs.c
@@ -377,10 +377,7 @@
     if (irq_num < 0 || irq_num > 31)
         return;
     sr = uic->uicsr;
-    if (!(uic->uicpr & mask)) {
-        /* Negatively asserted IRQ */
-        level = level == 0 ? 1 : 0;
-    }
+
     /* Update status register */
     if (uic->uictr & mask) {
         /* Edge sensitive interrupt */
@@ -479,7 +476,6 @@
         break;
     case DCR_UICPR:
         uic->uicpr = val;
-        ppcuic_trigger_irq(uic);
         break;
     case DCR_UICTR:
         uic->uictr = val;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]