Re: [Qemu-devel] [4239] x86/x86-64 MMU PAE fixes

[Paul Brook]

On Tuesday 22 April 2008, Aurelien Jarno wrote:
> -#define PHYS_ADDR_MASK 0xfffff000
> +#define PHYS_ADDR_MASK (~0xfff)

I think this is wrong. According to my docs physical addresses have an 
architectural limit of 52 bits. Bits 52-62 of a PTE are reserved (must be 
zero), and bit 63 is the NX bit.

You already reverted the following, but I'm going to mention it anyway:

> -#elif defined(TARGET_X86_64) && !defined(USE_KQEMU)
> -#define TARGET_PHYS_ADDR_SPACE_BITS 40

I think this should either be 52, or cpu specific.

Paul