qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [RFC][PATCH 4/4] Add support for Marvell 88w8618 /

From: Stuart Brady
Subject: Re: [Qemu-devel] Re: [RFC][PATCH 4/4] Add support for Marvell 88w8618 / MusicPal
Date: Mon, 14 Apr 2008 14:12:09 +0100
User-agent: Mutt/1.5.13 (2006-08-11) 
On Mon, Apr 14, 2008 at 08:59:30AM +0200, Jan Kiszka wrote:
> malc wrote:
> > Zero is not correct "mute" value for signed formats.
> 
> Hmm, maybe it's still too early for me - but what else??

Well, zero is not correct for unsigned formats, but I cannot see any
such formats in use in your emulation...

BTW, there are quite a few magic constants that it would probably be
better to #define.

Cheers,
-- 
Stuart Brady
reply via email to
[Prev in Thread] Current Thread [Next in Thread]