Re: [Qemu-devel] [PATCH 4/6] virtio network driver

[Paul Brook]

On Saturday 29 March 2008, Anthony Liguori wrote:
> +    if ((elem = virtqueue_pop(n->rx_vq)) == NULL) {
> +       /* wait until the guest adds some rx bufs */
> +       n->can_receive = 0;
> +       return;
> +    }

Setting can_receive to zero *after* dropping a packet is a bit late.
Not a fatal flaw, but it does make can_receive fairly useless. The whole point 
of can_receive is to workaround lack of proper TCP rate control in the slirp 
code.

Paul