Re: [Qemu-devel] [PATCH] Better version.rc patch

[Johannes Schindelin]

Hi,

On Fri, 8 Feb 2008, C.W. Betts wrote:

> Index: configure
> ===================================================================
> RCS file: /sources/qemu/qemu/configure,v
> retrieving revision 1.187
> diff -u -r1.187 configure
> --- configure 3 Feb 2008 19:20:13 -0000 1.187
> +++ configure 8 Feb 2008 22:48:30 -0000
> @@ -1065,6 +1065,10 @@
> echo "# Automatically generated by configure - do not modify" > $config_mak
> echo "/* Automatically generated by configure - do not modify */" > $config_h
> 
> +if test "$mingw32" = "yes" ; then
> +echo "#define QEMU_FILEVERSION 0,9,1,0" >> $config_h
> +echo "#define QEMU_PRODUCTVERSION 0,9,1,0" >> $config_h
> +fi

Well, that can go out of sync easily... why not something like

+echo "#define QEMU_FILEVERSION $(tr . , < VERSION),0" >> $config_h

Hmm?

> 0a1,22
> > #include "config.h"
> > 
> > 1 VERSIONINFO
> > FILEVERSION QEMU_FILEVERSION
> > PRODUCTVERSION QEMU_PRODUCTVERSION
> > FILETYPE 0x1 //VFT_APP
> >  {
> > BLOCK "StringFileInfo"
> >   {
> >   BLOCK "040904E4"
> >   {
> >    VALUE "FileDescription", "Qemu System emulator, " TARGET_ARCH " version"
> >    VALUE "FileVersion", QEMU_VERSION
> >    VALUE "LegalCopyright", "GNU General Public License"
> >    VALUE "ProductName", "Qemu"
> >   }
> >  }
> > BLOCK "VarFileInfo"
> >  {
> >   VALUE "Translation", 0x0409, 1252
> >  }
> > }

I see what you try to do, but I think this hunk lacks a proper diff header 
creating the file.  Something like

-- snip --
diff a/version.rc b/version.rc
--- /dev/null
+++ b/version.rc
-- snap --

Also, I see that you cut down the version.rc (for example, 
OriginalFilename is lacking now)... what are the symptoms of this not 
working?

Ciao,
Dscho