[Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2)

[Anthony Liguori]

Hi Izik,

Anthony Liguori wrote:
> Index: qemu/cpu-all.h
> ===================================================================
> --- qemu.orig/cpu-all.h 2008-02-01 15:24:45.000000000 -0600
> +++ qemu/cpu-all.h      2008-02-01 15:28:48.000000000 -0600
> @@ -695,7 +695,7 @@
>  
>  /* page related stuff */
>  
> -#define TARGET_PAGE_SIZE (1 << TARGET_PAGE_BITS)
> +#define TARGET_PAGE_SIZE (1ul << TARGET_PAGE_BITS)
>  #define TARGET_PAGE_MASK ~(TARGET_PAGE_SIZE - 1)
>  #define TARGET_PAGE_ALIGN(addr) (((addr) + TARGET_PAGE_SIZE - 1) & 
> TARGET_PAGE_MASK

Do you recall what this change fixed?  As Paul pointed out in IRC, using 
the host type here doesn't really fix the problem (target_ulong would be 
more appropriate).  However, we're both curious what problem it's 
actually fixing since sign extending the int should just work.

Regards,

Anthony Liguori