[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu softmmu_header.h
From: |
Johannes Schindelin |
Subject: |
Re: [Qemu-devel] qemu softmmu_header.h |
Date: |
Mon, 21 Jan 2008 19:02:13 +0000 (GMT) |
User-agent: |
Alpine 1.00 (LSU 882 2007-12-20) |
Hi,
On Mon, 21 Jan 2008, Fabrice Bellard wrote:
> Johannes Schindelin wrote:
>
> > On Mon, 21 Jan 2008, Fabrice Bellard wrote:
> >
> > > CVSROOT: /sources/qemu
> > > Module name: qemu
> > > Changes by: Fabrice Bellard <bellard> 08/01/21 15:07:18
> > >
> > > Modified files:
> > > . : softmmu_header.h
> > > Log message:
> > > fixed register constraint
> > >
> > > CVSWeb URLs:
> > > http://cvs.savannah.gnu.org/viewcvs/qemu/softmmu_header.h?cvsroot=qemu&r1=1.18&r2=1.19
> >
> > As has been pointed out already, this breaks compilation _at least_
> > with gcc 3.4.2 on MinGW.
>
> If it does, it is a very weird gcc bug. The previous code was clearly
> incorrect.
Ha! Your code compiles. And you know why? Because you only said "#if
DATA_SIZE == 1", and did not add " || DATA_SIZE == 2".
Now, I am out of my depth here; no idea what _should_ be correct.
Ciao,
Dscho
P.S.: Oh, and I ran a small Linux image with it, too, so it appears that
your patch does _not_ break anything. IOW I was wrong. Sorry.