[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} us
From: |
Thiemo Seufer |
Subject: |
Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter |
Date: |
Fri, 4 Jan 2008 13:20:39 +0000 |
User-agent: |
Mutt/1.5.17 (2007-11-01) |
Carlo Marcelo Arenas Belon wrote:
> Trivial fix that ensures that all buffers used for bdrv_read or bdrv_write
> are from an array of the uint8_t type
Do we have a host where this actually makes a difference?
Thiemo
> ---
> Index: block-vvfat.c
> ===================================================================
> RCS file: /sources/qemu/qemu/block-vvfat.c,v
> retrieving revision 1.16
> diff -u -p -r1.16 block-vvfat.c
> --- block-vvfat.c 24 Dec 2007 13:26:04 -0000 1.16
> +++ block-vvfat.c 4 Jan 2008 07:57:20 -0000
> @@ -340,7 +340,7 @@ typedef struct BDRVVVFATState {
> int current_fd;
> mapping_t* current_mapping;
> unsigned char* cluster; /* points to current cluster */
> - unsigned char* cluster_buffer; /* points to a buffer to hold temp data */
> + uint8_t* cluster_buffer; /* points to a buffer to hold temp data */
> unsigned int current_cluster;
>
> /* write support */
> Index: block.c
> ===================================================================
> RCS file: /sources/qemu/qemu/block.c,v
> retrieving revision 1.53
> diff -u -p -r1.53 block.c
> --- block.c 24 Dec 2007 16:10:43 -0000 1.53
> +++ block.c 4 Jan 2008 07:57:21 -0000
> @@ -459,7 +459,7 @@ int bdrv_commit(BlockDriverState *bs)
> BlockDriver *drv = bs->drv;
> int64_t i, total_sectors;
> int n, j;
> - unsigned char sector[512];
> + uint8_t sector[512];
>
> if (!drv)
> return -ENOMEDIUM;
>
>
>
- [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter, Carlo Marcelo Arenas Belon, 2008/01/04
- Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter,
Thiemo Seufer <=
- Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter, Andreas Färber, 2008/01/04
- Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter, Samuel Thibault, 2008/01/04
- Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter, Andreas Färber, 2008/01/04
- Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter, Thiemo Seufer, 2008/01/04
- Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter, M. Warner Losh, 2008/01/04
- Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter, Andreas Schwab, 2008/01/04
- Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter, Rob Landley, 2008/01/04
- Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter, Carlo Marcelo Arenas Belon, 2008/01/04